Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create GitHub action #91

Merged
merged 4 commits into from
Feb 22, 2022
Merged

create GitHub action #91

merged 4 commits into from
Feb 22, 2022

Conversation

Efreak
Copy link
Contributor

@Efreak Efreak commented Feb 22, 2022

This action will provide artifacts in the actions tab on GitHub after every push or pull request1. When a semver tag is pushed2, it'll also create a release for it and upload the artifacts to the release. You can see what the release looks like by looking at my fork (git tag v99.99.99; git push origin v99.99.99 gives you this) I'm sure there's a cleaner way to do this, but frankly I've spent hours on this already 3, and want to go do something else now.

If you want to, you can probably remove the circle ci option now.

Footnotes

  1. you can easily remove the pull request option. I left this in because sometimes people (quite often me) don't want too set up a dev environment to fix small issues.

  2. it doesn't like tags that aren't semver. It falls. No artifacts are uploaded.

  3. I've been lazy about learning GitHub actions until now

Efreak and others added 4 commits February 21, 2022 20:23
pass path to config file:
this was annoying to figure out. there's no manpage or other docs for this I
found the option at
goreleaser/goreleaser#2644
It's also annoying that I need this file at all; I feel that I should be able
to pass the options to goreleaser directly, but don't know how to.
apparently when I use this matrix, it sets this directory differently...

also fix windows binary names
@anacrolix
Copy link
Owner

I feel you with not being impressed by GitHub Actions. I've had similar issues trying to get it to do what I want over in anacrolix/torrent.

I think CircleCI is still doing unit tests and stuff, so until those are here in actions too, it might be appropriate to leave those running.

@anacrolix anacrolix changed the base branch from master to github-actions February 22, 2022 06:03
@anacrolix anacrolix merged commit c3dd06e into anacrolix:github-actions Feb 22, 2022
@anacrolix
Copy link
Owner

I merged into a new branch github-actions to let it run and see what happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants