Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split cmake file,botan3 support for macos, win, ubuntu, rockylinux #352

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hks2002
Copy link
Contributor

@hks2002 hks2002 commented Aug 30, 2024

Added option FETCH_BUILD_MISSING_DEPS to fetch and build dependencies in cmake.

  • With FETCH_BUILD_MISSING_DEPS ON, botan3 is supported for ubuntu and rockylinux and windows.
  • With this options on, users don't need to learn conan.

Windows could run the unit test now.

@hks2002 hks2002 changed the title split cmake file Split cmake file,botan3 support for win, ubuntu, rockylinux Sep 2, 2024
@hks2002
Copy link
Contributor Author

hks2002 commented Sep 2, 2024

@marty1885 @an-tao please review it.

@hks2002 hks2002 changed the title Split cmake file,botan3 support for win, ubuntu, rockylinux Split cmake file,botan3 support for macos, win, ubuntu, rockylinux Sep 2, 2024
@hks2002 hks2002 mentioned this pull request Sep 8, 2024
@an-tao
Copy link
Owner

an-tao commented Sep 9, 2024

@hks2002 感谢你的pr,这个pr涉及太多改动了,得谨慎,也许可以考虑先新建个分支。

@hks2002
Copy link
Contributor Author

hks2002 commented Sep 9, 2024

确实改动了很多, 等我在drogon仓库也一并改动完,再考虑合并的事情吧,现在的改动会影响drogon。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants