Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposes an RFC process #1

Merged
merged 2 commits into from
Aug 17, 2020
Merged

Proposes an RFC process #1

merged 2 commits into from
Aug 17, 2020

Conversation

Golodhros
Copy link
Member

Adds a Readme information with the proposed process for RFCs

Signed-off-by: Marcos Iglesias <[email protected]>
README.md Outdated

The "RFC" (request for comments) process is intended to provide a consistent and controlled path for new features to enter the [roadmap](roadmap).

The Amundsen team is still new to this processWe can handle most of the issues we see with regular GitHub issues., and we are actively developing it. We ask for feedback from the community to improve this approach, so don't hesitate to give us your feedback!
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in sentence.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Thanks!

Signed-off-by: Marcos Iglesias <[email protected]>
@feng-tao
Copy link
Member

should we disable github issues for this repo and make sure people only create PRs? also should we add a template (the feature one in github issue would be a good start)? maybe also request them to label as aip-N(Amundsen improvement proposal) which is a common acronym for other projects similar process (e.g KIP: https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals, AIP: https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)? What do others take on this?

@Golodhros
Copy link
Member Author

should we disable github issues for this repo and make sure people only create PRs? also should we add a template (the feature one in github issue would be a good start)? maybe also request them to label as aip-N(Amundsen improvement proposal) which is a common acronym for other projects similar process (e.g KIP: https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals, AIP: https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)? What do others take on this?

1.- I think disabling issues make sense. That said, Ember, Rust, React or Vue haven't done it on their RFC repos, and their issues are filled with feature requests. Probably not what we want, right?
2.- Yes, these same projects have several templates that I wanted to include. I liked the idea of having a new feature and feature deprecation templates like they have in Emberjs.
3.- Adding labels was one of the possible steps of the process, but AFAIK, non-maintainers cannot add labels.

@feng-tao
Copy link
Member

looking at https://github.com/rust-lang/rfcs which proposals spread across issues and pr which is confusing. I think we should disable issues and just request others to create pr for rfcs.

@verdan
Copy link
Member

verdan commented Aug 17, 2020

@Golodhros the only confusing part for me is the active state, which is basically 2 states, i.e., Working or Merged in master. How do people search for the RFCs which are available to be picked up?

How feasible is that to assign the RFC to a person, if he picks that up that means he is working on that. And if he wants to withdraw or if the original person is inactive and someone else wants to work on this then we can unassign the old person in favour of new one.

@Golodhros Golodhros merged commit 6aecd89 into master Aug 17, 2020
@Golodhros
Copy link
Member Author

@Golodhros the only confusing part for me is the active state, which is basically 2 states, i.e., Working or Merged in master. How do people search for the RFCs which are available to be picked up?

How feasible is that to assign the RFC to a person, if he picks that up that means he is working on that. And if he wants to withdraw or if the original person is inactive and someone else wants to work on this then we can unassign the old person in favour of new one.

Hi @verdan, thanks for your feedback!

The thing that other projects are doing with the RFCs is that they have at the top of the document a link a ticket on the main repository that tracks the work of the RFC. That means that we'll use the ticket on github.com/amundsen-io/amundsen to assign people and discuss about it.

To search for work to do, our contributors will use the main repo issues, filtering by labels like "Status: Accepted" and "Status: In Progress"

@feng-tao feng-tao deleted the mi-rfc-process branch March 10, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants