Skip to content

Commit

Permalink
feat: Use query parameter for basic search [AtlasProxy] (#105)
Browse files Browse the repository at this point in the history
* 🎉 Initial commit.

* 🔥 Removing code or files.
  • Loading branch information
mgorsk1 authored May 29, 2020
1 parent 5c864e7 commit 9961fde
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions search_service/proxy/atlas.py
Original file line number Diff line number Diff line change
Expand Up @@ -208,13 +208,7 @@ def fetch_table_search_results(self, *,
# return empty result for blank query term
return SearchResult(total_results=0, results=[])

# @todo switch to search with 'query' not 'filters' once Atlas FreeTextSearchProcessor is fixed
# https://reviews.apache.org/r/72440/
filters = [(self.ATLAS_QN_ATTRIBUTE, 'CONTAINS', query_term)]

# conduct search using filter on qualifiedName (it already contains both dbName and tableName)
# and table description
query_params = self._prepare_basic_search_query(self.page_size, page_index, filters=filters, operator='OR')
query_params = self._prepare_basic_search_query(self.page_size, page_index, query_term=query_term)

tables, approx_count = self._atlas_basic_search(query_params)

Expand Down

0 comments on commit 9961fde

Please sign in to comment.