-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add AWS SQS publisher and example job file. #431
Conversation
Signed-off-by: Wonyeong Choi <[email protected]>
Signed-off-by: Wonyeong Choi <[email protected]>
Signed-off-by: Wonyeong Choi <[email protected]>
Signed-off-by: Wonyeong Choi <[email protected]>
Signed-off-by: Wonyeong Choi <[email protected]>
f5b5ad6
to
53e2bbc
Compare
Signed-off-by: Wonyeong Choi <[email protected]>
Signed-off-by: Wonyeong Choi <[email protected]>
Signed-off-by: Wonyeong Choi <[email protected]>
209fd4c
to
c64521d
Compare
besides unit test, is the pr ready for review? exciting about supporting sqs publisher in databuilder etl pattern! |
This pr is ready. but, I want you to review both this pr and the other pr which implement extractor which extracts metadata from sqs. I'm currently working on extractor PR. |
sg, thanks @Wonong |
@Wonong just to check, have you had the chance to continue the pr? |
@feng-tao sorry for no progress... I had been busy these days. but, I can continue the pr soon if you don't mind |
@Wonong that would be great! |
Signed-off-by: Wonyeong Choi <[email protected]>
6a3020a
to
c930fcd
Compare
Signed-off-by: Wonyeong Choi <[email protected]>
c930fcd
to
3af4653
Compare
@feng-tao |
Hey @Wonong, I'd suggest using a We're now in a code-freeze period as part of the monorepo transition. If you can get this landed in the next few days, I'll cleanly transfer it over to the new repo. If not, it'll need to be manually re-opened against the new repo. |
sorry for late answer. I think i need more time. so, i will manually open it if needed. thank you for inform :) |
OK, happy to review on the monorepo :) |
Summary of Changes
Tests
Test it using container executing sample job periodically using crontab and it works.
test repo: https://github.com/Wonong/ab-metadata-pusher
Documentation
https://github.com/Wonong/ab-metadata-pusher
CheckList
Make sure you have checked all steps below to ensure a timely review.
make test