feat: Vertica metadata extractor #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanzgiri
changed the title
feng-tao
reviewed
Jan 27, 2021
sanzgiri
requested review from
allisonsuarez,
dikshathakur3119 and
jinhyukchang
as code owners
Adding a metadata extractor for Vertica using MySQL as template Signed-off-by: Ashutosh Sanzgiri <[email protected]>
Signed-off-by: Ashutosh Sanzgiri <[email protected]>
Signed-off-by: Ashutosh Sanzgiri <[email protected]>
feng-tao
reviewed
Feb 1, 2021
| CLUSTER_KEY config parameter is used as cluster name | ||
| Not distinguishing between table & view for now | ||
| """ | ||
| # SELECT statement from vertica information_schema to extract table and column metadata |
There was a problem hiding this comment.
do you need any vertica deps to use this extractor?
There was a problem hiding this comment.
Sure, I can add a section in the README in the top directory of the repo, under the List of Extractors.
I can also add an example as a file example/scripts/vertica_data_loader.py that shows how the extractor can be used.
Signed-off-by: Ashutosh Sanzgiri <[email protected]>
Signed-off-by: Ashutosh Sanzgiri <[email protected]>
Signed-off-by: Ashutosh Sanzgiri <[email protected]>
Signed-off-by: Ashutosh Sanzgiri <[email protected]>
Signed-off-by: Ashutosh Sanzgiri <[email protected]>
feng-tao
approved these changes
Feb 4, 2021
3 tasks
Wonong
pushed a commit
to Wonong/amundsendatabuilder
that referenced
this pull request
Mar 4, 2021
* Adding metadata extractor for Vertica Adding a metadata extractor for Vertica using MySQL as template Signed-off-by: Ashutosh Sanzgiri <[email protected]> * renaming appropriately Signed-off-by: Ashutosh Sanzgiri <[email protected]> * reordering imports Signed-off-by: Ashutosh Sanzgiri <[email protected]> * add docs for vertica extractor Signed-off-by: Ashutosh Sanzgiri <[email protected]> * fix lint errors Signed-off-by: Ashutosh Sanzgiri <[email protected]> * fix isort errors Signed-off-by: Ashutosh Sanzgiri <[email protected]> * fix isort errors Signed-off-by: Ashutosh Sanzgiri <[email protected]> * fix isort errors Signed-off-by: Ashutosh Sanzgiri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Adding a metadata extractor for Vertica
Summary of Changes
Adding metadata extractor for Vertica
Tests
Confirmed extractor works in a local installation.
Can contribute a sample_vertica_loader.py file
No tests added, but could add. Please provide pointers on doing this.
Documentation
None so for
CheckList
Make sure you have checked all steps below to ensure a timely review.
make test