Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(imperator): fix false positive about monthly_character_experience #161

Merged

Conversation

IhateTrains
Copy link
Contributor

When used in country scope, it represents Monthly Statesmanship:

	country_modifier = {
		research_points_modifier = 0.05
		max_research_efficiency = 0.15
		monthly_character_experience = 0.05
	}

image

@amtep
Copy link
Owner

amtep commented Feb 3, 2025

I'm confused about this one, because your example shows monthly_character_experience but the commit changes "happiness_for_wrong_religion_modifier

@IhateTrains IhateTrains changed the title fix(imperator): fix false positive about happiness_for_wrong_religion_modifier fix(imperator): fix false positive about monthly_character_experience Feb 5, 2025
@IhateTrains
Copy link
Contributor Author

@amtep sorry, it looks like a mistake. The PR now modifies monthly_character_experience.

@amtep amtep merged commit f9e12f8 into amtep:main Feb 8, 2025
5 of 6 checks passed
@IhateTrains IhateTrains deleted the happiness_for_wrong_religion_modifier-fix branch February 8, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants