channel: better comment for body frame payload size #455
Annotations
1 error and 19 warnings
rustfmt
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
|
rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
using `map` over `inspect`:
src/buffer.rs#L239
warning: using `map` over `inspect`
--> src/buffer.rs:239:28
|
239 | before(s, tmp).map(|s| {
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
= note: `-W clippy::manual-inspect` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::manual_inspect)]`
help: try
|
239 ~ before(s, tmp).inspect(|s| {
240 ~ s.write.rollback(end);
|
|
associated items `drop_frames_for_channel` and `drop_pending_frames_for_channel` are never used:
src/frames.rs#L273
warning: associated items `drop_frames_for_channel` and `drop_pending_frames_for_channel` are never used
--> src/frames.rs:273:8
|
138 | impl Inner {
| ---------- associated items in this implementation
...
273 | fn drop_frames_for_channel(&mut self, channel_id: ChannelId, error: Error) {
| ^^^^^^^^^^^^^^^^^^^^^^^
...
280 | fn drop_pending_frames_for_channel(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
method `drop_frames_for_channel` is never used:
src/frames.rs#L107
warning: method `drop_frames_for_channel` is never used
--> src/frames.rs:107:19
|
29 | impl Frames {
| ----------- method in this implementation
...
107 | pub(crate) fn drop_frames_for_channel(&self, channel_id: ChannelId, error: Error) {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
methods `update_recovery_context`, `finalize_recovery`, and `set_reconnecting` are never used:
src/channel_status.rs#L36
warning: methods `update_recovery_context`, `finalize_recovery`, and `set_reconnecting` are never used
--> src/channel_status.rs:36:19
|
15 | impl ChannelStatus {
| ------------------ methods in this implementation
...
36 | pub(crate) fn update_recovery_context<F: Fn(&mut ChannelRecoveryContext)>(&self, apply: F) {
| ^^^^^^^^^^^^^^^^^^^^^^^
...
43 | pub(crate) fn finalize_recovery(&self) {
| ^^^^^^^^^^^^^^^^^
...
80 | pub(crate) fn set_reconnecting(&self, error: Error) {
| ^^^^^^^^^^^^^^^^
|
associated items `new`, `cause`, and `set_expected_replies` are never used:
src/channel_recovery_context.rs#L16
warning: associated items `new`, `cause`, and `set_expected_replies` are never used
--> src/channel_recovery_context.rs:16:19
|
15 | impl ChannelRecoveryContext {
| --------------------------- associated items in this implementation
16 | pub(crate) fn new(cause: Error) -> Self {
| ^^^
...
25 | pub(crate) fn cause(&self) -> Error {
| ^^^^^
...
33 | pub(crate) fn set_expected_replies(
| ^^^^^^^^^^^^^^^^^^^^
|
method `reset` is never used:
src/acknowledgement.rs#L182
warning: method `reset` is never used
--> src/acknowledgement.rs:182:8
|
92 | impl Inner {
| ---------- method in this implementation
...
182 | fn reset(&mut self, error: Error) {
| ^^^^^
|
method `reset` is never used:
src/acknowledgement.rs#L66
warning: method `reset` is never used
--> src/acknowledgement.rs:66:19
|
22 | impl Acknowledgements {
| --------------------- method in this implementation
...
66 | pub(crate) fn reset(&self, error: Error) {
| ^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
docs
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
docs
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
docs
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
docs
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|