-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support priority queue declarations #180
Conversation
@ebardes you already can use priority queues with any client that supports optional queue arguments. While I couldn't quickly find an example of how to do that with this client in either examples or tests, I'd be really surprised if amqp.node didn't provide a way to do that. |
I couldn't find a way to declare a queue with the 'x-max-priority' flag. Perhaps I just missed it or that I'm not familiar enough with the nuances of amqp.node yet. If you declare a queue through the management interface, the runtime code errors because the queue declarations don't match. |
Ah, so there's known argument filtering going on. |
Exactly. I just added another known argument. |
This is very important for us! When do you plan to perform a new release with this included? |
@squaremo this PR looks good to me. |
Tested with RabbitMQ 3.3.4 broker and it seems to create the queues successfully, ignoring the x-max-priority option making the change backwards compatible |
No there's not .. I see why you'd think that though. The second argument to
whereas the "known options" go in the top level:
Anyway, yes this PR looks fine. |
Support priority queue declarations
@nikosd23 all unknown |
I'm working on project that benefits from using priority queues in RabbitMQ (available since version 3.5.x). I feel that others might benefit from this functionality too.