Consider removing readable-stream?

[jimmywarting]

I would like it if readable-stream didn't have to be installed / downloaded.
they don't seem to be used much at all...
it looks like this everywhere:

require('stream').<x> || require('readable-stream/<x>') 

is it okey to remove it?

[cressie176]

I think you're right. I'll try removing and running with Node 10.

[cressie176]

Removed. Thanks @jimmywarting

[lobokoch]

After I updated from version amqplib: 0.10.3 to amqplib: 0.10.5, when I run my application I got the error: (node:31412) UnhandledPromiseRejectionWarning: Error: Cannot find module 'readable-stream'.
NOTE: I'm using Node v20.15.0.

[cressie176]

Thanks for the report @lobokoch, I'll try running the tests with that node version and see what happens

[cressie176]

@lobokoch I've run the tests using node v20.15.0 and they run fine. I've also grep'd the code base and the string 'readable-stream' only appears in a single comment, so nothing in amqplib 0.10.5 can be requiring it. Is it possible some other code in your application is relying on readable-stream being installed by amqplib, and now that it is has been removed is failing?

What does the stacktrace show?

[cressie176]

Closing on assumption that the issue is something other than amqplib is dependent on readable-stream but has not declared it as a dependency.