Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No existing functionality to pass in query params in url object #229

Closed
JasonTowner opened this issue Feb 3, 2016 · 1 comment
Closed

No existing functionality to pass in query params in url object #229

JasonTowner opened this issue Feb 3, 2016 · 1 comment

Comments

@JasonTowner
Copy link

amqp support query string params to allow further options on the connection. They are only available with amqplib if your param type is a url connection string; if you pass in an object, there is no support for the query string as an object.

Missing functionality

frameMax
channelMax
heartbeat
locale
@JasonTowner JasonTowner mentioned this issue Feb 3, 2016
Closed
ikhemissi added a commit to ikhemissi/amqp.node that referenced this issue Nov 10, 2016
@ikhemissi
Specify heartbeat with object configuration
bb1e6c8 
Provide extra settings inside the object configuration that were only available from url configs
like heartbeat interval.

Closes amqp-node#229
@ikhemissi ikhemissi mentioned this issue Nov 10, 2016
Merged
@ikhemissi
Copy link
Contributor

Hi,

I added an other PR for the same issue, but the difference is that the extra configuration (e.g. heartbeat) is expected in the url param of connect instead of socketOptions: https://github.com/ikhemissi/amqp.node/blob/bb1e6c8efd6ec2d4598512cdedb793527f764b47/lib/connect.js#L90

I'm happy with whichever PR (#226 or #304) gets merged first, and I'm also happy to make any changes in the #304 to make it follow any contribution guidelines or roadmap goals.

Thanks guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JasonTowner @ikhemissi