-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress Console Messages in AMP output #609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably delegate logging instead so we can be consistent with AMP's logging system.
I thought that Renovate would have automatically opened a PR to update |
Hey @westonruter, we purposely disable renovate-bot for dependencies. https://github.com/ampproject/amphtml/blob/master/renovate.json#L13 |
I'll upgrade amphtml soon. |
This was true for both |
Each distributed thread's code for
amp-script
integration includes additional logging information.This PR removes the logging since it can impact performance.This PR uses the similar to AMP logic for retaining logs (presence of
development
orlog
inlocation.hash
.Edit: Changed approach based on PR feedback.