Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more descriptive type signature for tuples #1107

Merged
merged 3 commits into from
Oct 30, 2021

Conversation

cometkim
Copy link
Contributor

No description provided.

src/main-thread/install.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@kristoferbaxter kristoferbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really good idea. Thank you and @samouri for making the code more readable!

@kristoferbaxter kristoferbaxter merged commit 79ed3f7 into ampproject:main Oct 30, 2021
@cometkim cometkim deleted the descriptive-tuple branch May 20, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants