nodom: workerDOM should be document.defaultView #1091
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Fixes ampproject/amphtml#35902
DocumentLite.ts
toDocumentStub.ts
. The filename should match the exported class :)workerDOM
export to actually be thedocument.defaultView
which is essential for propagating properties (localStorage/sessionStorate) to the globalself
. This is also how the regular binary works. See below snippetsworker-dom/src/main-thread/worker.ts
Line 80 in 11ff429
worker-dom/src/worker-thread/index.amp.ts
Line 137 in 11ff429
testing done
Copied the built binaries over to a local
amphtml
and confirmed that localStorage access was available onself