Skip to content

Commit

Permalink
be smarter (attach to process.env for var replacment)
Browse files Browse the repository at this point in the history
  • Loading branch information
samouri committed Sep 27, 2021
1 parent 162e42f commit 1d19033
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 10 deletions.
2 changes: 1 addition & 1 deletion config/rollup.worker-thread.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const ESModules = [
replace({
values: {
WORKER_DOM_DEBUG: false,
IS_SERVER: true,
'process.env.SERVER': true,
},
preventAssignment: true,
}),
Expand Down
1 change: 0 additions & 1 deletion src/main-thread/main-thread.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,3 @@ type RenderableElement = (HTMLElement | SVGElement | Text | Comment) & {

declare const WORKER_DOM_DEBUG: boolean;
declare const IS_AMP: boolean;
declare const IS_SERVER: boolean;
4 changes: 2 additions & 2 deletions src/test/Emitter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export function emitter(document: Document): Emitter {
subscribers.delete(callback);
}

document.postMessage = (message: MutationFromWorker, buffers: Array<ArrayBuffer>) => {
document.postMessage = ((message: MutationFromWorker, buffers: Array<ArrayBuffer>) => {
strings.push(...message[TransferrableKeys.strings]);

let copy = new Map(subscribers);
Expand All @@ -38,7 +38,7 @@ export function emitter(document: Document): Emitter {
}
callback(strings, message, buffers);
});
};
}) as any;
document[TransferrableKeys.observe]();

return {
Expand Down
2 changes: 1 addition & 1 deletion src/worker-thread/MutationTransfer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ let pendingMutations: Array<number> = [];

// TODO(choumx): Change `mutation` to Array<Uint16> to prevent casting errors e.g. integer underflow, precision loss.
export function transfer(document: Document | DocumentStub, mutation: Array<number>): void {
if (IS_SERVER) {
if (process.env.SERVER) {
return;
}

Expand Down
2 changes: 1 addition & 1 deletion src/worker-thread/dom/Node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export abstract class Node {
this.nodeType = nodeType;
this.nodeName = nodeName;
this.ownerDocument = ownerDocument || this;
if (IS_SERVER) {
if (process.env.SERVER) {
return;
}

Expand Down
4 changes: 2 additions & 2 deletions src/worker-thread/nodes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const mapping: Map<number, Node> = new Map();
*/
export function storeOverride(node: Node, override: number): number {
// Server version of the lib never transfers.
if (IS_SERVER) {
if (process.env.SERVER) {
return 0;
}

Expand All @@ -34,7 +34,7 @@ export function storeOverride(node: Node, override: number): number {
*/
export function store(node: Node): number {
// Server version of the lib never transfers.
if (IS_SERVER) {
if (process.env.SERVER) {
return 0;
}

Expand Down
2 changes: 1 addition & 1 deletion src/worker-thread/strings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const mapping: Map<string, number> = new Map();
*/
export function store(value: string): number {
// Server version of the lib never transfers.
if (IS_SERVER) {
if (process.env.SERVER) {
return 0;
}

Expand Down
1 change: 0 additions & 1 deletion src/worker-thread/worker-thread.d.ts

This file was deleted.

0 comments on commit 1d19033

Please sign in to comment.