Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Disallow empty CTA string in page attachment #39351

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

ychsieh
Copy link
Contributor

@ychsieh ychsieh commented Aug 9, 2023

Also manually add page-attachment script to the template htmls, which is to avoid the script installation errors that only happen in local dev environment.

Context: #39299

Also manually add page attachment script to example html to avoid script installation errors
@amp-owners-bot
Copy link

amp-owners-bot bot commented Aug 9, 2023

Hey @gmajoulet, @newmuis, @mszylkowski! These files were changed:

extensions/amp-story-page-attachment/0.1/amp-story-open-page-attachment.js
extensions/amp-story-page-attachment/0.1/test/test-amp-story-open-page-attachment.js

@ychsieh ychsieh requested a review from erwinmombay August 9, 2023 11:27
@ychsieh
Copy link
Contributor Author

ychsieh commented Aug 11, 2023

cc @Pateriack

@ychsieh ychsieh merged commit 2b33a9a into ampproject:main Aug 14, 2023
@ampprojectbot
Copy link
Member

Warning: disparity between this PR Percy build and its main build

The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the main branch that this PR was merged into, and there appears to be a mismatch between the two.

This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build / main commit's Percy build > and determine further action:

  • If the disparity appears to be caused by this PR, please create an bug report or send out a new PR to fix
  • If the disparity appears to be a flake, please @-mention ampproject/wg-approvers in a comment
  • If there is no disparity and this comment was created by mistake, please @-mention ampproject/wg-infra
  • If unsure, @-mention ampproject/wg-approvers

eszponder pushed a commit to krzysztofequativ/amphtml that referenced this pull request Apr 22, 2024
Also manually add page attachment script to example html to avoid script installation errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants