Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Fix PR titles and remove reviewer teams #28483

Merged
merged 5 commits into from
May 19, 2020

Conversation

rcebulko
Copy link
Contributor

Iterations on renovate config.

@rcebulko rcebulko requested a review from rsimha May 18, 2020 22:30
.renovaterc.json Show resolved Hide resolved
@rcebulko
Copy link
Contributor Author

For posterity, the reviewers list appears to support team names of the form "team:my-team-slug" (source). When I tried with "team:wg-infra", it failed to add anyone as a reviewer. I suspect the bot may require org:read permissions to add a team as a reviewer. I'm trying a full team slug, ie. "team:@ampproject/wg-infra" based on wg-calypso, which has renovate successfully assigning team reviewers (example).

@rcebulko
Copy link
Contributor Author

After a lot of digging and testing on my own org/repo, I've determined that teams cannot be assigned as reviewers by the renovate app on the GitHub marketplace due to permissions issues (see renovatebot/renovate#1908 for details). I've removed all reviewer team settings here. Instead, we'll allow renovate to create the PRs, then Owners Bot will assign them appropriately based on the existing owners configuration. Every package.json file is already owned by the teams we would have assigned, so we get the randomized reviewer assignment for free, and the grouping should reduce the number of PRs enough that the load is manageable.

@rcebulko rcebulko changed the title 🏗 Add PR body notes, sample 2 reviewers, and fix PR titles 🏗 Fix PR titles and remove reviewer teams May 19, 2020
@rcebulko rcebulko merged commit f83ed6c into ampproject:master May 19, 2020
@rcebulko rcebulko deleted the regroup branch May 19, 2020 02:14
@rcebulko
Copy link
Contributor Author

Related to #28322

@noahtallen
Copy link

I'm trying a full team slug, ie. "team:@ampproject/wg-infra" based on wg-calypso, which has renovate successfully assigning team reviewers (example).

Funny enough, I'm trying to get it working again for team calypso. It appears the example you linked was probably using codeowners instead of renovate. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants