Skip to content

Commit

Permalink
Removed CID param from the request (#39283)
Browse files Browse the repository at this point in the history
* added pixel. prefix to the domain

* rerun the previous tests

* added pixel. prefix again and try to run the tests

* removed cid

* fixed tests to not expect cid in play request
  • Loading branch information
dimitarandonov authored Aug 9, 2023
1 parent c90c7dd commit 17fb660
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion extensions/amp-analytics/0.1/test/vendor-requests.json
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@
"impression_params": "<ignore for test>",
"custom_params": "<ignore for test>",
"impression": "<ignore for test>",
"audio-play": "https://pixel.%21regionid-config%21environment.sensic.net/tp?m=!mediaID&v=1.0.0&t=s2s-amp&ty=PL&c=default&ut=_timestamp_&pr=_page_view_id_!streamID&rn=1&vt=1&sp=-1&st=_timestamp_&sn=_counter(play__page_view_id_!streamID)_&!custom_params&optin=!optin&gdpr=1&gdpr_consent=_consent_string_&ext_amp_cid=_client_id(cid)_&r=_ampdoc_host_&ua=_user_agent_&l=_browser_language_",
"audio-play": "https://pixel.%21regionid-config%21environment.sensic.net/tp?m=!mediaID&v=1.0.0&t=s2s-amp&ty=PL&c=default&ut=_timestamp_&pr=_page_view_id_!streamID&rn=1&vt=1&sp=-1&st=_timestamp_&sn=_counter(play__page_view_id_!streamID)_&!custom_params&optin=!optin&gdpr=1&gdpr_consent=_consent_string_&r=_ampdoc_host_&ua=_user_agent_&l=_browser_language_",
"audio-stop": "https://pixel.%21regionid-config%21environment.sensic.net/tp?m=!mediaID&v=1.0.0&t=s2s-amp&ty=ST&c=default&ut=_timestamp_&pr=_page_view_id_!streamID&rn=1&vt=1&sp=-1&st=_timestamp_&sn=_counter(stop__page_view_id_!streamID)_"
},
"googleadwords": {
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-analytics/0.1/vendors/gfksensic.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"requests": {
"base": "/tp?m=${mediaID}&v=${v}&t=s2s-amp",
"page_params": "r=${r}&ua=${ua}&l=${l}",
"user_params": "optin=${optin}&gdpr=1&gdpr_consent=${consentString}&ext_amp_cid=${clientId(cid)}",
"user_params": "optin=${optin}&gdpr=1&gdpr_consent=${consentString}",
"streaming_params": "c=${contentID}&ut=${ut}&pr=${pr}&rn=${rn}&vt=${vt}&sp=${sp}&st=${st}",
"impression_params": "c=${contentID}&pr=RANDOM",
"custom_params": "",
Expand Down

0 comments on commit 17fb660

Please sign in to comment.