Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict JSON validation to non-LD scripts #4431

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Restrict JSON validation to non-LD scripts #4431

merged 1 commit into from
Mar 24, 2020

Conversation

westonruter
Copy link
Member

Summary

Fixes #4430.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added this to the v1.5 milestone Mar 24, 2020
@westonruter westonruter requested a review from amedina March 24, 2020 04:14
@googlebot googlebot added the cla: yes Signed the Google CLA label Mar 24, 2020
@westonruter westonruter requested a review from kienstra March 24, 2020 04:20
@westonruter westonruter requested a review from pierlon March 24, 2020 04:24
pierlon
pierlon approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@pierlon pierlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended, :shipit: .

@westonruter westonruter merged commit 3f6e89e into develop Mar 24, 2020
@westonruter westonruter deleted the fix/ld-json-validation branch March 24, 2020 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierlon pierlon pierlon approved these changes

@amedina amedina Awaiting requested review from amedina

@kienstra kienstra Awaiting requested review from kienstra

Assignees
No one assigned
Labels
cla: yes Signed the Google CLA
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

AMP validation error due to to empty LD+JSON script
3 participants
@westonruter @pierlon @googlebot