Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate experimental support for service worker streaming for PWA plugin #3059

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Eliminate experimental support for service worker streaming for PWA plugin #3059

merged 1 commit into from
Aug 22, 2019

Conversation

westonruter
Copy link
Member

@westonruter westonruter added this to the v1.2.2 milestone Aug 20, 2019
@googlebot googlebot added the cla: yes Signed the Google CLA label Aug 20, 2019
@westonruter westonruter requested a review from schlessera August 21, 2019 18:43
schlessera
schlessera approved these changes Aug 21, 2019
View reviewed changes
Copy link
Collaborator

@schlessera schlessera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert looks clean.

However, as this was merged almost a year ago, I'm not 100% certain there's not other functionality that relies on this. A bit of searching through tickets did not show up much, so I suppose it is good to go.

@westonruter westonruter mentioned this pull request Aug 21, 2019
Merged
@westonruter westonruter merged commit b4d41d5 into develop Aug 22, 2019
@westonruter westonruter deleted the remove/pwa-streaming branch August 22, 2019 18:38
@westonruter westonruter modified the milestones: v1.2.2, v1.3 Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera schlessera approved these changes

Assignees
No one assigned
Labels
cla: yes Signed the Google CLA Integration: PWA
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@westonruter @schlessera @googlebot