Wait until content loaded before calculating font size. #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miina
commented
Aug 20, 2019
| } | ||
|
|
||
| const anonymousUserName = __( 'Anonymous', 'amp' ); | ||
| return anonymousUserName.toLowerCase() !== blockContent.toLowerCase(); |
There was a problem hiding this comment.
Not sure if this might cause issues in some cases (or not work), perhaps there's a better way to check if the content has loaded. Thoughts?
There was a problem hiding this comment.
That seems a bit overly complicated.
Why not just return an isLoading prop or so in the withSelect part further down?
The component itself shouldn't be concerned with deciding that.
I suppose isLoading could mean either getEditedPostAttribute() or getAuthors() is returning undefined.
There was a problem hiding this comment.
Yep, that makes 100x more sense. 🤦♀
|
@swissspidy Would you mind reviewing again to get it to 1.2.1? |
westonruter
added a commit
that referenced
this pull request
Aug 22, 2019
* tag '1.2.1': (434 commits) Bump 1.2.1 Adjust block inserter style. (#3075) Update dependency eslint-plugin-jest to v22.15.2 Fix flaky CTA test (#3057) Add more resizing handles (#3023) Bump version to 1.2.1-RC1 Improve story page background media with image srcset, reduced image size, and a11y text (#3006) Wait until content loaded before calculating font size. (#3052) Harden logic for normalizing image metadata before adding story images (#3049) Update dependency uuid to v3.3.3 (#3046) Inline color support (#3033) Update dependency webpack-cli to v3.3.7 (#3040) Tiny prop-types fix Update dependency babel-jest to v24.9.0 (#3037) Update e2e test setup (#3031) Include amp-script among dynamic_element_selectors in tree shaking Another try to fix tests. Ensure selecting the first page before removing the block. Move setting input selection to the end to helpers. Fix editor test. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3047
Waits until the author block's content is loaded before calculating the font size.
Looks like the content switched quickly from
Anonymousto the actual username, resulting in updating block attributes so that the update foranonymousfont-size was applied later than the real font size.This PR checks if the author block's content is loaded before calculation.