[AMP Stories] Text Block

[swissspidy]

Work in progress

Smart text block that replaces/combines the paragraph and heading blocks.

See #1883.

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[swissspidy]

^ eb61fc6 contains my personal email address as a co-author, hence the googlebot warning. Should be all good now.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[miina]

A few notes from testing the block -- let me know if these are not happening for you:

• When adding an animation while having more than one Text block, sometimes the following error occurred:
  TypeError: Cannot read property 'replace' of undefined at eval (webpack-internal:///./assets/src/components/animation-controls.js:50:45)
  Another error occurred while trying to use the "Begin After" setting.
• Adding animation doesn't seem to get saved (choose animation settings => save => refresh) and causes block validation errors;
• At this moment when clicking "Return" in the Text block adds a break (br) instead of creating a new block -- is this intended?

Let me know if it works as expected for you or if perhaps some animation parts are not intended to work at this moment (tested on WP 5.1).

[miina]

^ One more finding in addition to these: choosing the font family doesn't seem to be reflected in the editor at this moment.

[swissspidy]

When adding an animation while having more than one Text block, sometimes the following error occurred
Adding animation doesn't seem to get saved

Noticed that too today while working on animations. Probably a leftover from when I introduced some foundation for animation ordering in #1896. Already being addressed in #1904.

At this moment when clicking "Return" in the Text block adds a break (br) instead of creating a new block -- is this intended?

I've intentionally left out key handling like this at the moment. With #1897 in mind it felt a bit odd. I think we can add it in a separate PR later if needed.

Choosing the font family doesn't seem to be reflected in the editor at this moment.

Hmm would have to test this. At first glance I can't see why this particular PR would have broken this. But font selection is undergoing quite some changes in #1885 anyway.

[miina]

Hmm would have to test this. At first glance I can't see why this particular PR would have broken this. But font selection is undergoing quite some changes in #1885 anyway.

Yes, you're right about not being related to this PR, it doesn't seem to be working in the general AMP Stories branch either.

[miina]

@swissspidy FYI: I'll fix the font-family issue in a separate PR, it's related to the wrapperProps not being assigned as expected and causes some other issues, too.

[miina]

It has some conflicts now but otherwise LGTM!