Remove unneeded width & height checks #914
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isTinyNode()
method first ensures that all negative or zero values of eitherwidth
orheight
are eliminated.Then, after a check for responsiveness, it checks the
width
andheight
again for being a positive value. At his point, this is guaranteed to be true already by the first check, and thus only adds unneeded processing overhead.This PR removes these unneeded checks, assuming that the initial check is correct.