Feature/linter optimizer checks #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if we should somehow add the recommendation to the linter rule (for example in the info field). |
|
|
||
| export class IsTransformedAmp extends Rule { | ||
| run({ $ }: Context) { | ||
| const isTransformed = $("html[transformed='self;v=1']").length > 0; |
There was a problem hiding this comment.
Checking for the presence of transformed is enough. The content might change.
|
|
||
| export class ModuleRuntimeUsed extends Rule { | ||
| run({ $ }: Context) { | ||
| const isTransformed = $("html[transformed='self;v=1']").length > 0; |
There was a problem hiding this comment.
Might make sense to extract this into a helper method. We'll need it more often.
| return this.pass(); | ||
| } | ||
| const isModuleVersion = | ||
| $("script[type='module'][src='https://cdn.ampproject.org/v0.mjs']") |
There was a problem hiding this comment.
Just check for /v0.mjs to support runtime self-hosting in the future.
| return isModuleVersion | ||
| ? this.pass() | ||
| : this.warn( | ||
| "The Java Script module version of the AMP Runtime is not used" |
There was a problem hiding this comment.
s/Java Script/JavaScript
caroqliu
approved these changes
Aug 18, 2020
sebastianbenz
approved these changes
Aug 18, 2020
|
Build failure is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing linter page experience checks for