Only inject runtime-host meta tag if host is given #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only include host in runtime-host meta tag * Print warning if ampUrlPrefix is not absolute * Don't inject runtime-host meta tag if ampUrlPrefix is not absolute. This will fallback to cdn.ampproject.org.
tharders
pushed a commit
that referenced
this pull request
Aug 17, 2020
* Only include host in runtime-host meta tag * Print warning if ampUrlPrefix is not absolute * Don't inject runtime-host meta tag if ampUrlPrefix is not absolute. This will fallback to cdn.ampproject.org.
mdmower
reviewed
Sep 25, 2021
| versionlessHost = '.'; | ||
| try { | ||
| const url = new URL(host); | ||
| this._addMeta(head, 'runtime-host', url.origin); |
There was a problem hiding this comment.
This introduced a regression. It used to be possible to specify a host like https://example.com/amp-runtime. This strips away /amp-runtime, resulting in incorrect URLs for dynamically loaded extensions.
mdmower
added a commit
to mdmower/amp-toolbox
that referenced
this pull request
Oct 3, 2021
PR ampproject#855 introduced two regressions: - It became impossible to specify a runtime-host with a path in the URL (e.g. https://example.com/amp-runtime) - The --rtv flag led to inconsistent AMP script URLs because runtime-host dropped /rtv/<rtv> One of the advertised features of self-hosting from https://github.com/ampproject/amphtml/blob/main/docs/spec/amp-framework-hosting.md is: - serve AMP pages and the framework from the same host, potentially improving content delivery times. For this to be possible, the runtime should be served from a path under the same domain as the amp pages.
sebastianbenz
pushed a commit
that referenced
this pull request
Oct 4, 2021
PR #855 introduced two regressions: - It became impossible to specify a runtime-host with a path in the URL (e.g. https://example.com/amp-runtime) - The --rtv flag led to inconsistent AMP script URLs because runtime-host dropped /rtv/<rtv> One of the advertised features of self-hosting from https://github.com/ampproject/amphtml/blob/main/docs/spec/amp-framework-hosting.md is: - serve AMP pages and the framework from the same host, potentially improving content delivery times. For this to be possible, the runtime should be served from a path under the same domain as the amp pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fallback to cdn.ampproject.org.