Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Empty <amp-experiment> blocks boilerplate removal #581

Merged
merged 3 commits into from
Jan 24, 2020
Merged

Fix: Empty <amp-experiment> blocks boilerplate removal #581

merged 3 commits into from
Jan 24, 2020

Conversation

sebastianbenz
Copy link
Collaborator

Fixes #578

@sebastianbenz
Copy link
Collaborator Author

@schlessera PTAL

schlessera
schlessera suggested changes Jan 24, 2020
View reviewed changes
Copy link
Collaborator

@schlessera schlessera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic is inverted.

Also, two of the spec files need to be adapted as their tags are empty, which should not be enough for the scenario they test:

packages/optimizer/lib/transformers/ServerSideRendering.js Outdated Show resolved Hide resolved
@sebastianbenz
Copy link
Collaborator Author

Hah! Fooled myself there. Thanks for noticing. Should be fixed now. I've also added more tests and improved the test names. @schlessera PTAL

@schlessera
Copy link
Collaborator

LGTM!

@sebastianbenz sebastianbenz merged commit c303ec8 into master Jan 24, 2020
@sebastianbenz
Copy link
Collaborator Author

Thanks for the review!

@sebastianbenz sebastianbenz deleted the amp-experiment-empty branch January 24, 2020 18:04
This was referenced Sep 11, 2020
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera schlessera requested changes

@andreban andreban Awaiting requested review from andreban

Assignees
No one assigned
Labels
bug cla: yes toolbox-optimizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty <amp-experiment> blocks boilerplate removal
3 participants
@sebastianbenz @schlessera @googlebot