fmigrate to htmlparser2 #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianbenz
force-pushed
the
htmlparser2
branch
3 times, most recently
from
87eea80 to
972d4eb
Compare
* no more monkey patching the node model * better compatibility with other tools relying on the htmlparser2 API * smaller output files as `=""` is no longer rendered * faster (not sure yet how much)
sebastianbenz
force-pushed
the
htmlparser2
branch
from
972d4eb to
d60b748
Compare
andreban
requested changes
Jan 21, 2020
| @@ -64,7 +64,7 @@ async function customAmpTransformation(filePath, html) { | |||
| } | |||
| transform(tree, params) { | |||
| this.log_.info('Running custom transformation for ', params.filePath); | |||
| const html = tree.root.firstChildByTag('html'); | |||
| const html = firstChildByTag(tree, 'html'); | |||
There was a problem hiding this comment.
nit: I do prefer firstChildByTag(tree, 'html') instead of tree.root.firstChildByTag('html'). I wonder if we could have tree.firstChildByTab('html'), similar to the call on line 69.
| 'use strict'; | ||
|
|
||
| const {Element, DataNode} = require('domhandler'); | ||
| const domUtils = require('domutils'); |
There was a problem hiding this comment.
We're requiring the entire domutils here and then a few selected methods below. Do we need both?
There was a problem hiding this comment.
it's to avoid a name conflict
| @@ -64,7 +64,7 @@ async function customAmpTransformation(filePath, html) { | |||
| } | |||
| transform(tree, params) { | |||
| this.log_.info('Running custom transformation for ', params.filePath); | |||
| const html = tree.root.firstChildByTag('html'); | |||
| const html = firstChildByTag(tree, 'html'); | |||
| if (!html) return; | |||
| const head = html.firstChildByTag('head'); | |||
There was a problem hiding this comment.
I think this is the only place firstChildByTag is being used in this format. Wondering if this is actually wrong?
| img.attribs.src = src; | ||
| img.attribs.alt = ''; | ||
| async addBlurryPlaceholder_(src) { | ||
| const img = createElement('img', { |
| try { | ||
| expectedOutput = getFileContents(expectedOutputPath); | ||
| } catch (e) { | ||
| // no snapshot written yet |
There was a problem hiding this comment.
nit: I don't really understand what this comment means. Maybe it's worth explaining more?
|
@andreban PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
=""is no longer rendered