Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Add icomoon #1149

Merged
merged 3 commits into from
Feb 26, 2021
Merged

🔧 Add icomoon #1149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfad7f8
:wrench: Add more font-famlies
lluerich Feb 26, 2021
f244a7b
:wrench: Remove octicons
lluerich Feb 26, 2021
80d1e65
:white_check_mark: Add some more tests
lluerich Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/linter/src/rules/NoIconFontIsUsed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,13 @@ const ICON_FONT_IDENTIFIERS = [
className: "icofont-",
fontFamilies: ["IcoFont"],
},
{
className: "octicon-",
fontFamilies: ["Octicons"],
},
{
className: "icn-",
fontFamilies: ["icon"],
},
{
className: "icon-",
fontFamilies: ["icon"],
fontFamilies: ["icon", "icons", "icomoon"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case? Have we already got tests for all the icon font providers?

},
];

Expand Down
32 changes: 28 additions & 4 deletions packages/linter/tests/local.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,38 +253,62 @@ describe(FastGoogleFontsDisplay.name, () => {
});

describe(NoIconFontIsUsed.name, () => {
it(`${NoIconFontIsUsed.name} - icon font usage`, async () => {
it(`${NoIconFontIsUsed.name} - icon font found`, async () => {
return assertWarn(
runLocalTest(
NoIconFontIsUsed,
`${__dirname}/local/NoIconFontIsUsed-1/source.html`
)
);
});
it(`${NoIconFontIsUsed.name} - no icon font usage`, async () => {
it(`${NoIconFontIsUsed.name} - no icon font found`, async () => {
return assertPass(
runLocalTest(
NoIconFontIsUsed,
`${__dirname}/local/NoIconFontIsUsed-2/source.html`
)
);
});
it(`${NoIconFontIsUsed.name} - suspicious class names, but no icon font`, async () => {
it(`${NoIconFontIsUsed.name} - suspicious class names`, async () => {
return assertPass(
runLocalTest(
NoIconFontIsUsed,
`${__dirname}/local/NoIconFontIsUsed-3/source.html`
)
);
});
it(`${NoIconFontIsUsed.name} - usage of material icons icon font`, async () => {
it(`${NoIconFontIsUsed.name} - material icons icon font found`, async () => {
return assertWarn(
runLocalTest(
NoIconFontIsUsed,
`${__dirname}/local/NoIconFontIsUsed-4/source.html`
)
);
});
it(`${NoIconFontIsUsed.name} - icomoon icon font found`, async () => {
return assertWarn(
runLocalTest(
NoIconFontIsUsed,
`${__dirname}/local/NoIconFontIsUsed-5/source.html`
)
);
});
it(`${NoIconFontIsUsed.name} - icofont icon font found`, async () => {
return assertWarn(
runLocalTest(
NoIconFontIsUsed,
`${__dirname}/local/NoIconFontIsUsed-6/source.html`
)
);
});
it(`${NoIconFontIsUsed.name} - nerd font icon font found`, async () => {
return assertWarn(
runLocalTest(
NoIconFontIsUsed,
`${__dirname}/local/NoIconFontIsUsed-7/source.html`
)
);
});
});

describe(FontsArePreloaded.name, () => {
Expand Down
Binary file removed packages/linter/tests/local/NoIconFontIsUsed-1/fontawesome/webfonts/fa-solid-900.eot
View file
Open in desktop
Binary file not shown.
5,028 changes: 0 additions & 5,028 deletions ...ges/linter/tests/local/NoIconFontIsUsed-1/fontawesome/webfonts/fa-solid-900.svg
View file
Open in desktop

This file was deleted.

Binary file removed packages/linter/tests/local/NoIconFontIsUsed-1/fontawesome/webfonts/fa-solid-900.ttf
View file
Open in desktop
Binary file not shown.
Binary file removed packages/linter/tests/local/NoIconFontIsUsed-1/fontawesome/webfonts/fa-solid-900.woff
View file
Open in desktop
Binary file not shown.
Binary file removed packages/linter/tests/local/NoIconFontIsUsed-1/fontawesome/webfonts/fa-solid-900.woff2
View file
Open in desktop
Binary file not shown.
57 changes: 57 additions & 0 deletions packages/linter/tests/local/NoIconFontIsUsed-5/source.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
<!doctype html>
<html amp lang="en">
<head>
<meta charset="utf-8">
<script async src="https://cdn.ampproject.org/v0.js"></script>
<title>Hello, AMPs</title>
<link rel="canonical" href="http://example.ampproject.org/article-metadata.html">
<meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1">
<script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "NewsArticle",
"headline": "Open-source framework for publishing content",
"datePublished": "2015-10-07T12:02:41Z",
"image": [
"logo.jpg"
]
}
</script>
<style amp-boilerplate>body{-webkit-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-moz-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-ms-animation:-amp-start 8s steps(1,end) 0s 1 normal both;animation:-amp-start 8s steps(1,end) 0s 1 normal both}@-webkit-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-moz-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-ms-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-o-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}</style><noscript><style amp-boilerplate>body{-webkit-animation:none;-moz-animation:none;-ms-animation:none;animation:none}</style></noscript>
<style amp-custom>
@font-face {
font-family: 'icomoon';
src: url('fonts/icomoon.eot?72kag1');
src: url('fonts/icomoon.eot?72kag1#iefix') format('embedded-opentype'),
url('fonts/icomoon.ttf?72kag1') format('truetype'),
url('fonts/icomoon.woff?72kag1') format('woff'),
url('fonts/icomoon.svg?72kag1#icomoon') format('svg');
font-weight: normal;
font-style: normal;
font-display: block;
}

[class^="icon-"], [class*=" icon-"] {
/* use !important to prevent issues with browser extensions that change fonts */
font-family: 'icomoon' !important;
speak: never;
font-style: normal;
font-weight: normal;
font-variant: normal;
text-transform: none;
line-height: 1;

/* Better Font Rendering =========== */
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
}

.icon-power:before {
content: "\e9b5";
}
</style>
</head>
<body>
<h1>Hello, AMP!<span class="icon-power"></span></h1>
</body>
</html>
54 changes: 54 additions & 0 deletions packages/linter/tests/local/NoIconFontIsUsed-6/source.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
<!doctype html>
<html amp lang="en">
<head>
<meta charset="utf-8">
<script async src="https://cdn.ampproject.org/v0.js"></script>
<title>Hello, AMPs</title>
<link rel="canonical" href="http://example.ampproject.org/article-metadata.html">
<meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1">
<script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "NewsArticle",
"headline": "Open-source framework for publishing content",
"datePublished": "2015-10-07T12:02:41Z",
"image": [
"logo.jpg"
]
}
</script>
<style amp-boilerplate>body{-webkit-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-moz-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-ms-animation:-amp-start 8s steps(1,end) 0s 1 normal both;animation:-amp-start 8s steps(1,end) 0s 1 normal both}@-webkit-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-moz-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-ms-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-o-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}</style><noscript><style amp-boilerplate>body{-webkit-animation:none;-moz-animation:none;-ms-animation:none;animation:none}</style></noscript>
<style amp-custom>
@font-face {
font-family: "IcoFont";
font-weight: normal;
font-style: "Regular";
src: url("./fonts/icofont.woff2") format("woff2"),
url("./fonts/icofont.woff") format("woff");
}

[class^="icofont-"], [class*=" icofont-"] {
font-family: 'IcoFont' !important;
speak: none;
font-style: normal;
font-weight: normal;
font-variant: normal;
text-transform: none;
white-space: nowrap;
word-wrap: normal;
direction: ltr;
line-height: 1;
/* Better Font Rendering =========== */
-webkit-font-feature-settings: "liga";
-webkit-font-smoothing: antialiased;
}

.icofont-thunder-light:before {
content: "\ee84";
}
</style>
</head>
<body>
<h1>Hello, AMP!<i class="icofont-thunder-light"></i></h1>
</body>
</html>
50 changes: 50 additions & 0 deletions packages/linter/tests/local/NoIconFontIsUsed-7/source.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
<!doctype html>
<html amp lang="en">
<head>
<meta charset="utf-8">
<script async src="https://cdn.ampproject.org/v0.js"></script>
<title>Hello, AMPs</title>
<link rel="canonical" href="http://example.ampproject.org/article-metadata.html">
<meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1">
<script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "NewsArticle",
"headline": "Open-source framework for publishing content",
"datePublished": "2015-10-07T12:02:41Z",
"image": [
"logo.jpg"
]
}
</script>
<style amp-boilerplate>body{-webkit-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-moz-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-ms-animation:-amp-start 8s steps(1,end) 0s 1 normal both;animation:-amp-start 8s steps(1,end) 0s 1 normal both}@-webkit-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-moz-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-ms-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-o-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}</style><noscript><style amp-boilerplate>body{-webkit-animation:none;-moz-animation:none;-ms-animation:none;animation:none}</style></noscript>
<style amp-custom>
@font-face {
font-family: 'NerdFontsSymbols Nerd Font';
src: url("./fonts/Noto Sans Regular Nerd Font Complete.ttf") format("truetype");
font-weight: normal;
font-style: normal;
}

.nf, .nerd-font, .nerd-fonts {
font-family: 'NerdFontsSymbols Nerd Font';
speak: none;
font-style: normal;
font-weight: normal;
font-variant: normal;
text-transform: none;
line-height: 1;
/* Better Font Rendering (from devicons, et al) */
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
}

.nf-fa-bolt:before {
content: "\f0e7";
}
</style>
</head>
<body>
<h1>Hello, AMP!<i class="nf nf-fa-bolt"></i></h1>
</body>
</html>