♻️ Refine icon font detection #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lluerich
commented
Feb 25, 2021
lluerich
commented
- adds selectors
- selector is now case-insensitive
- print warning instead of failure
- update copy to match other warnings
| @@ -26,6 +26,14 @@ const ICON_FONT_IDENTIFIERS = [ | |||
| className: "ociton-", | |||
| fontFamilies: ["icon"], | ||
| }, | ||
| { | ||
| className: "icon-", |
There was a problem hiding this comment.
This is a super generic name which I wouldn't warn about without the font name.
| @@ -35,7 +43,7 @@ export class NoIconFontIsUsed extends Rule { | |||
| run({ $ }: Context) { | |||
| // check for known classnames | |||
| const iconFontCandidates = ICON_FONT_IDENTIFIERS.filter((identifier) => { | |||
| return $(`[class*=${identifier.className}]`).length > 0; | |||
| return $(`[class*=${identifier.className} i]`).length > 0; | |||
There was a problem hiding this comment.
Out of curiosity, what does the i do here?
sebastianbenz
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.