Don't preload hero images #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't tell whether a hero image is responsive and is loaded depending on viewport size. The current implementation will always preload hero images, which means images might be preloaded even if they are not visible on the page. This PR reverts this behavior and disables preload generation for hero images. The only exception is when an image defines a media attribute.
| preload.attribs.media = heroImage.media; | ||
| if (!heroImage.media) { | ||
| // We can only safely preload a hero image if there's a media attribute | ||
| // as we can't detect whether it's hidden on certain viewport sizes otherwise. |
There was a problem hiding this comment.
Why? Is it an opt in sort of thing, or does the media attr provide some kind of indication of..something?
There was a problem hiding this comment.
This is AMP's built in way to define per element media queries. The assumption is that if you use this, you won't define additional media queries in CSS. This could still lead to false positives, but I suspect that this is seldom the case.
sebastianbenz
added a commit
that referenced
this pull request
Jan 29, 2021
This PR makes image optimization more flexible by making it possible to configure hero image count and blurry image placeholder generation on a per page basis. This PR also deprecates the preloadHeroImage option in favor of a new optimizeHeroImages option as preloading has been disabled in most cases (see #1132).
sebastianbenz
added a commit
that referenced
this pull request
Jan 29, 2021
This PR makes image optimization more flexible by making it possible to configure hero image count and blurry image placeholder generation on a per page basis. This PR also deprecates the preloadHeroImage option in favor of a new optimizeHeroImages option as preloading has been disabled in most cases (see #1132).
sebastianbenz
added a commit
that referenced
this pull request
Jan 29, 2021
This PR makes image optimization more flexible by making it possible to configure hero image count and blurry image placeholder generation on a per page basis. This PR also deprecates the preloadHeroImage option in favor of a new optimizeHeroImages option as preloading has been disabled in most cases (see #1132).
sebastianbenz
added a commit
that referenced
this pull request
Feb 1, 2021
This PR makes image optimization more flexible by making it possible to configure hero image count and blurry image placeholder generation on a per page basis. This PR also deprecates the preloadHeroImage option in favor of a new optimizeHeroImages option as preloading has been disabled in most cases (see #1132).
sebastianbenz
added a commit
that referenced
this pull request
Feb 1, 2021
* More flexible hero images and blurry placeholders This PR makes image optimization more flexible by making it possible to configure hero image count and blurry image placeholder generation on a per page basis. This PR also deprecates the preloadHeroImage option in favor of a new optimizeHeroImages option as preloading has been disabled in most cases (see #1132). * improve wording * log deprecated option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't tell whether a hero image is responsive and is loaded depending
on viewport size. The current implementation will always preload hero
images, which means images might be preloaded even if they are not
visible on the page. This PR reverts this behavior and disables
preload generation for hero images.
The only exception is when an image defines a media attribute.