Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(blocks): Remove () and (void) before block declarations #307

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

JanNash
Copy link
Contributor

@JanNash JanNash commented Oct 21, 2020

Summary

This PR unifies the declarations of blocks without input parameters and without return value.
They are now all declared like this ^{ instead of ^(){ or ^(void){. This is consistent with
the majority of declarations for blocks like this in the codebase.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@haoliu-amp haoliu-amp merged commit 18710c5 into amplitude:master Oct 21, 2020
@JanNash JanNash deleted the style/unify-block-declarations branch October 21, 2020 16:47
@github-actions
Copy link

🎉 This PR is included in version 7.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants