Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Podfile validation #306

Merged
merged 2 commits into from
Oct 20, 2020
Merged

ci: Podfile validation #306

merged 2 commits into from
Oct 20, 2020

Conversation

jooohhn
Copy link
Contributor

@jooohhn jooohhn commented Oct 20, 2020

Summary

  • Use pod lib lint instead of pod spec lint
    • pod lib lint validates local code, while pod spec lint validates remote code associated with current tag
    • Example: The release of v7.1.1 had a false positive validation because pod spec lint was validating v7.1.0 instead
  • Add podfile validation to test.yml
  • Current CI check will fail because of warnings that will be fixed in future PR

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: NO

@jooohhn jooohhn requested a review from haoliu-amp October 20, 2020 21:22
@jooohhn jooohhn merged commit 32995c2 into master Oct 20, 2020
@jooohhn jooohhn deleted the podfile-validation branch October 20, 2020 22:03
@github-actions
Copy link

🎉 This PR is included in version 7.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoliu-amp haoliu-amp haoliu-amp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jooohhn @haoliu-amp