Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add back support for proxy #597

Merged
merged 1 commit into from
Nov 22, 2023
Merged

feat: add back support for proxy #597

merged 1 commit into from
Nov 22, 2023

Conversation

ertanden
Copy link
Contributor

Re-Fixes #388

Seems like during migration to AWS SDK v3, the proxy support was broken.

This pull request;

  • Adds proxy support with the proxy-agent package, so that env variables like http_proxy etc are taken into account.

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rddimon rddimon merged commit 0a047d4 into amplify-education:main Nov 22, 2023
3 of 5 checks passed
@rddimon rddimon mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rddimon rddimon rddimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to setup base domain behind HTTP proxy
2 participants
@ertanden @rddimon