fix: fix getCustomDomainInfo function to different APIGateway versions #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @aalongkott Thank you for your contribution! |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hello @rddimon I have fixed the unit tests according to the bugs. Please review and if the coverage does not match your requirements, please tell me. |
rddimon
approved these changes
Jan 31, 2023
This was referenced Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #536
Description of Issue Fixed
endpointTypeandsecurityPolicyChanges proposed in this pull request:
endpointType== "EDGE" andsecurityPolicy== "TLS_1_0". Otherwise, using APIGateway version 2.