Add split horizon dns support #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overbit
force-pushed
the
add-split-horizon-dns-support
branch
from
b961200 to
e885f60
Compare
|
@rddimon do you know whom is the best person to review this PR? |
|
Guys, please review this one. We really need the change. |
|
@dnicolson @kevinle-1 anything that you guys can help with? |
|
Unfortunately no, I'm not an admin. |
|
Also unfortunately not an admin 😥 I think you'll need a review from @rddimon assuming they are the active maintainer |
|
Hi, thanks for the PR. We will try to get it reviewed as soon as possible. |
|
@aoskotsky-amplify any updates? |
|
Hi there I will try to take a look this week |
|
Kudos, SonarCloud Quality Gate passed!
|
rddimon
approved these changes
Oct 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #239
Description of Issue Fixed
Introduce new settings to allow configuration of Custom Domain in split-horizon DNS setups.
When a
splitHorizonDnsis set, Route53 records will be created in both, private and public, hosted zones matching the domain name.Changes proposed in this pull request: