Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds error logging for getDomainName API fail #434

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/aws/api-gateway-wrapper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ class APIGatewayWrapper {
}

/**
* Delete Custom Domain Name through API Gateway
* Get Custom Domain Info through API Gateway
*/
public async getCustomDomainInfo(domain: DomainConfig): Promise<DomainInfo> {
// Make API call
Expand All @@ -102,6 +102,7 @@ class APIGatewayWrapper {
return new DomainInfo(domainInfo);
} catch (err) {
if (err.code !== "NotFoundException") {
Globals.logError(err, domain.givenDomainName);
throw new Error(`Unable to fetch information about ${domain.givenDomainName}`);
}
Globals.logError(`${domain.givenDomainName} does not exist`);
Expand Down