Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #332 #337

Merged
merged 2 commits into from
May 11, 2020
Merged

Fixes #332 #337

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9b81a0
Fixes #332
fabiancook May 9, 2020
7076ff0
Correct linting
fabiancook May 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ class ServerlessCustomDomain {
// Use APIGateway (v1) for EDGE domains
if (domain.endpointType === Globals.endpointTypes.edge) {
const params = {
basePath: domain.apiMapping.ApiMappingKey,
basePath: domain.apiMapping.ApiMappingKey || "(none)",
domainName: domain.givenDomainName,
patchOperations: [
{
Expand Down