Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch exports from cloudformation if used Fn::ImportValue #220

Merged

Conversation

sampsasaarela
Copy link
Contributor

Fixes #219

Description of Issue Fixed
Added support to define restApiId by Fn::ImportValue. It just basically fetch exports via cloudformation api and try to find value by name.

@captainsidd captainsidd self-requested a review June 19, 2019 14:51
@omry-hay
Copy link

Hi @captainsidd,

I encountered this issue as well and found out this PR is open for ~4 months now.
Can you please merge it so we can use this fix?

Thanks

@venturno
Copy link

Hello, I'd like this PR to be merged as well since I'm being affected by the same issue

@ianmarcinkowski
Copy link

Hi, also bumping this. We are also affected at my company!

Thanks!

@lightningspirit
Copy link

Hello, being affected as well. Is this solution good to go or do you have any concerns?

@Warsaalk
Copy link

Warsaalk commented Feb 3, 2020

We also need this! Have been using this pull request for a while now, it's looking good!

@thomasviaud
Copy link

Can somebody merge that feature please?

@renanbatel
Copy link

renanbatel commented Apr 17, 2020

I was facing the same issue, I use a shared API Gateway resource through different services and was getting the exported API Id with Fn::ImportValue. I managed to merge these changes to version 3.3.1 manually and everything is working as expected. Thanks.

@mountainraptor
Copy link

@captainsidd This is also affecting our stack. Would be helpful to have integrated!

@avinasherupaka
Copy link

@captainsidd This is also affecting our stack. Would be helpful to have integrated!

@RickMeasham
Copy link

RickMeasham commented Sep 2, 2020

Hi all, this has just bitten me to. The PR has been open for five months and it now has conflicts. Can we work to get this deployed?

@sampsasaarela if you could update your PR so that @aoskotsky-amplify, @jconstance-amplify or someone else with write access can merge it?

I'm sure the time to review and merge will be far less than the time that 14 or more people have spent hunting this down.

Thanks everyone! (Especially @sampsasaarela for getting a patch ready!)

Update: It's 2020. This PR has been open for a year and five months!

@RickMeasham
Copy link

Thank you @rddimon!

@Warsaalk
Copy link

Warsaalk commented Oct 2, 2020

Thanks !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create basepath mapping when using Fn::ImportValue for restApiId in serverless.yml