-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch exports from cloudformation if used Fn::ImportValue #220
fetch exports from cloudformation if used Fn::ImportValue #220
Conversation
Hi @captainsidd, I encountered this issue as well and found out this PR is open for ~4 months now. Thanks |
Hello, I'd like this PR to be merged as well since I'm being affected by the same issue |
Hi, also bumping this. We are also affected at my company! Thanks! |
Hello, being affected as well. Is this solution good to go or do you have any concerns? |
We also need this! Have been using this pull request for a while now, it's looking good! |
Can somebody merge that feature please? |
I was facing the same issue, I use a shared API Gateway resource through different services and was getting the exported API Id with |
@captainsidd This is also affecting our stack. Would be helpful to have integrated! |
@captainsidd This is also affecting our stack. Would be helpful to have integrated! |
Hi all, this has just bitten me to. The PR has been open for five months and it now has conflicts. Can we work to get this deployed? @sampsasaarela if you could update your PR so that @aoskotsky-amplify, @jconstance-amplify or someone else with write access can merge it? I'm sure the time to review and merge will be far less than the time that 14 or more people have spent hunting this down. Thanks everyone! (Especially @sampsasaarela for getting a patch ready!) Update: It's 2020. This PR has been open for a year and five months! |
Thank you @rddimon! |
Thanks !! |
Fixes #219
Description of Issue Fixed
Added support to define restApiId by
Fn::ImportValue
. It just basically fetch exports via cloudformation api and try to find value by name.