Refactor #181
Merged
Refactor #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 16, 2019 10:06
captainsidd
commented
Jan 22, 2019
captainsidd
commented
Jan 22, 2019
added 20 commits
January 23, 2019 12:49
added 2 commits
February 1, 2019 17:45
| * Lifecycle function to delete basepath mapping | ||
| * Wraps deletion of basepath mapping | ||
| */ | ||
| public async removeBasePathMapping(): Promise<void> { |
There was a problem hiding this comment.
Not sure if we need a wrapper function here since its a 1 liner. Could put thee contents of deleteBasePathMapping in here
There was a problem hiding this comment.
I like the idea of making the lifecycle functions and the actual API calls separate - just consistent with the rest of the codebase.
package.json
Outdated
| @@ -30,7 +30,7 @@ | |||
| "test": "tsc --project . && nyc mocha -r ts-node/register test/unit-tests/index.test.ts && nyc report --reporter=text-summary", | |||
| "integration-test": "node ./node_modules/istanbul/lib/cli.js test _mocha test/integration-tests -- -R spec", | |||
| "lint": "tslint --project .", | |||
| "build": "tsc --project . && npm publish" | |||
There was a problem hiding this comment.
Do we need the publish command?
There was a problem hiding this comment.
Nope - Travis runs npm publish, that's why I specified just compiling before Travis deploys
3797bb5#diff-354f30a63fb0907d4ad57269548329e3R14
added 2 commits
February 4, 2019 11:34
aoskotsky-amplify
approved these changes
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Change
Version 3.0.0
delete_domainidempotent (does not error out if no domain to be deleted), closes Please make delete_domain operation idempotent #150