Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Mutual TLS authentication #503

Closed
nestor-bolivar opened this issue Jun 2, 2022 · 3 comments · Fixed by #505
Closed

Enable Mutual TLS authentication #503

nestor-bolivar opened this issue Jun 2, 2022 · 3 comments · Fixed by #505

Comments

@nestor-bolivar
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Feature Request

Is your feature request related to a problem? Please describe.

API gateway provide us with a method to authenticate http requests using client-server certificates. We are missing this option. Refer to https://aws.amazon.com/blogs/compute/introducing-mutual-tls-authentication-for-amazon-api-gateway/

Describe the solution you'd like
A clear and concise description of what you want to happen. Add any considered drawbacks, and what serverless.yml would look like:

custom:
  customDomain:
    tlsTruststore: 's3://my-bucket/my-trust.pem'

Describe alternatives you've considered
Move to terraform

Any Other Info
If you can, maybe sketch out implementation details? If you've started a PR for this feature, link it here.

@cjuega
Copy link

cjuega commented Jun 21, 2022

I'm working on a PR. Would this setup work for you?

custom:
  customDomain:
    tlsTruststoreUri: 's3://my-bucket/my-trust.pem'
    tlsTruststoreVersion: 'optional s3 object version'

@nestor-bolivar
Copy link
Author

nestor-bolivar commented Jun 21, 2022

Hey @cjuega . That will certainly do the job.
Feel free to share your feature branch, so we could see the progress 🤞

cjuega pushed a commit to cjuega/serverless-domain-manager that referenced this issue Jun 22, 2022
cjuega pushed a commit to cjuega/serverless-domain-manager that referenced this issue Jun 22, 2022
cjuega pushed a commit to cjuega/serverless-domain-manager that referenced this issue Jun 24, 2022
@cjuega
Copy link

cjuega commented Jun 24, 2022

@nestor-bolivar here it is 😄

cjuega pushed a commit to cjuega/serverless-domain-manager that referenced this issue Jun 24, 2022
cjuega pushed a commit to cjuega/serverless-domain-manager that referenced this issue Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants