Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expiration to lock queue, remove token from queue on timeout #62

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Add expiration to lock queue, remove token from queue on timeout #62

merged 2 commits into from
Oct 24, 2019

Conversation

kelunik
Copy link
Member

@kelunik kelunik commented Oct 22, 2019

Fixes #61.

@kelunik kelunik requested a review from trowski October 22, 2019 18:33
trowski
trowski reviewed Oct 24, 2019
View reviewed changes
trowski
trowski approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@trowski trowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and fixes the issue I was having. LGTM except for the unused imports.

@kelunik kelunik merged commit fe670a2 into master Oct 24, 2019
@kelunik kelunik deleted the issue-61 branch October 24, 2019 21:59
@kelunik kelunik restored the issue-61 branch October 24, 2019 21:59
@kelunik kelunik deleted the issue-61 branch October 24, 2019 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trowski trowski trowski approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timed-out lock never released
2 participants
@kelunik @trowski