You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If I understand correctly: $queue is emptied in #137, but the old reference is stored in $temp.
In the while-loop the array_shift call on (now empty) $queue will always return null.
I don't know the bigger picture with the $temp dereferencing, but only with the local context, I guess in #142 it should use $temp instead of $queue.
The text was updated successfully, but these errors were encountered:
Hi,
Thanks for your handy library.
With the newest 1.x version we found a (possible) bug:
https://github.com/amphp/redis/blob/1.x/src/RemoteExecutor.php#L135C17-L145C18
introduced with
ed5555e
If I understand correctly:
$queue
is emptied in #137, but the old reference is stored in$temp
.In the while-loop the
array_shift
call on (now empty)$queue
will always returnnull
.I don't know the bigger picture with the
$temp
dereferencing, but only with the local context, I guess in #142 it should use$temp
instead of$queue
.The text was updated successfully, but these errors were encountered: