Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: load default config if none specified #1246

Merged
merged 2 commits into from
Nov 27, 2021
Merged

fix: load default config if none specified #1246

merged 2 commits into from
Nov 27, 2021

Conversation

oxytocin
Copy link
Contributor

@oxytocin oxytocin commented Nov 16, 2021 •
edited by Nytelife26
Loading

Avoids crash in Python if configuration is not specified. Fixes #1240.

@oxytocin oxytocin changed the title Load default config if none specified Closes #1240 Load default config if none specified Nov 16, 2021
@oxytocin oxytocin mentioned this pull request Nov 16, 2021
Closed
@Nytelife26 Nytelife26 added bug: confirmed Bugs that were confirmed in triage. priority: high Issues and PRs that should be resolved as soon as possible. status: wip Issues and PRs that are still a work in progress. type: fix Issues and PRs related to bugs. version: patch Issues and PRs with bug fixes belonging to the next patch release. labels Nov 26, 2021
Nytelife26
Nytelife26 previously requested changes Nov 26, 2021
View reviewed changes
@Nytelife26 Nytelife26 dismissed their stale review November 26, 2021 13:25

Obsoleted by latest commit.

@codecov
Copy link

codecov bot commented Nov 26, 2021 •
edited
Loading

Codecov Report

Merging #1246 (225b55c) into main (f7faa72) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1246   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files          83       83           
  Lines        1170     1170           
=======================================
  Hits         1105     1105           
  Misses         65       65
Flag Coverage Δ
macos-latest 94.44% <100.00%> (ø)
py3.6 93.86% <100.00%> (ø)
py3.7 93.86% <100.00%> (ø)
py3.8 94.44% <100.00%> (ø)
py3.9 94.44% <100.00%> (ø)
pypypy3 93.86% <100.00%> (ø)
ubuntu-latest 94.44% <100.00%> (ø)
windows-latest 94.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
proselint/tools.py 87.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7faa72...225b55c. Read the comment docs.

Nytelife26
Nytelife26 approved these changes Nov 26, 2021
View reviewed changes
Copy link
Member

@Nytelife26 Nytelife26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the PR :)

@Nytelife26 Nytelife26 changed the title Load default config if none specified fix: load default config if none specified Nov 27, 2021
@Nytelife26 Nytelife26 merged commit ea8c574 into amperser:main Nov 27, 2021
@Nytelife26 Nytelife26 added bug: confirmed Bugs that were confirmed in triage. bug: fixed-in-next Bugs present in the current release but fixed on the main branch. and removed bug: confirmed Bugs that were confirmed in triage. labels Nov 27, 2021
@Nytelife26 Nytelife26 mentioned this pull request Apr 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nytelife26 Nytelife26 Nytelife26 approved these changes

@suchow suchow Awaiting requested review from suchow suchow is a code owner

Assignees
No one assigned
Labels
bug: confirmed Bugs that were confirmed in triage. bug: fixed-in-next Bugs present in the current release but fixed on the main branch. priority: high Issues and PRs that should be resolved as soon as possible. status: wip Issues and PRs that are still a work in progress. type: fix Issues and PRs related to bugs. version: patch Issues and PRs with bug fixes belonging to the next patch release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyError in Python
3 participants
@oxytocin @Nytelife26 @wavestats