Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detekt (Kotlin Codeanalysis) Integration #169

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Conversation

luca-dot-sh
Copy link
Contributor

@luca-dot-sh luca-dot-sh commented Dec 13, 2024

This PR

  • adds detekt codeanalysis to CI
  • fixes some of the detected code smells
  • enable R8 compiler / ProGuard

Memory Usage Comparison (release with R8 enabled):

  • PSS: 80 MB (debug) -> 24 MB (release)
  • APK Size: 46 MB (debug) -> 6 MB (release)

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@luca-dot-sh luca-dot-sh marked this pull request as draft December 13, 2024 14:34
@luca-dot-sh luca-dot-sh force-pushed the detekt_integration branch 2 times, most recently from 5121974 to 5b07d68 Compare December 13, 2024 16:34
@luca-dot-sh luca-dot-sh force-pushed the detekt_integration branch 2 times, most recently from 1831e5f to cbb4f67 Compare December 17, 2024 22:36
@luca-dot-sh luca-dot-sh changed the base branch from main to dev December 17, 2024 22:37
@luca-dot-sh luca-dot-sh marked this pull request as ready for review December 17, 2024 22:43
@luca-dot-sh luca-dot-sh changed the title IGNORE just testing detekt github integration Detekt (Kotlin Codeanalysis) Integration Dec 17, 2024
@luca-dot-sh luca-dot-sh requested a review from fhilgers December 17, 2024 22:43
Signed-off-by: Luca Bretting <[email protected]>
If you have a broken config, you need to delete it to stop the backend from crashing!

Signed-off-by: Luca Bretting <[email protected]>
Copy link
Collaborator

@fhilgers fhilgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@luca-dot-sh luca-dot-sh merged commit 3385948 into dev Dec 30, 2024
8 checks passed
@Mr-Kanister Mr-Kanister deleted the detekt_integration branch January 8, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants