Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply feedback on project structure #80

Closed
3 tasks done
luccalb opened this issue Nov 27, 2024 · 1 comment
Closed
3 tasks done

Apply feedback on project structure #80

luccalb opened this issue Nov 27, 2024 · 1 comment
Assignees
@dh1542
Labels
refactoring

Comments

@luccalb
Copy link

luccalb commented Nov 27, 2024 •
edited by dh1542
Loading

Description

  • Move only our components from pipelines/data_wranglers into pipelines/data_quality/data_manupulation. Move pipeline/monitoring to pipelines/data_quality/monitoring.

Originally posted by @luccalb in #57 (comment)

  • add copyright text to sdk/python/rtdip_sdk/pipelines/transformers/spark/machine_learning/__init__.py

Originally posted by @TugceOzberkYener in #57 (comment)

  • Rename ColsToVector to ColumnsToVector

Originally posted by @TugceOzberkYener in #57 (comment)

Acceptance criteria

Definition of Done

  • Test cases have been created and are running successfully
  • Documentation for the new component was added
  • Github Actions are running without errors
@luccalb luccalb moved this to Product Backlog in amos2024ws01-feature-board Nov 27, 2024
@luccalb luccalb changed the title Move data_wranglers to data_quality package Improve project structure Nov 27, 2024
@luccalb luccalb changed the title Improve project structure Apply feedback on project structure Nov 27, 2024
@luccalb luccalb moved this from Product Backlog to Sprint Backlog in amos2024ws01-feature-board Nov 27, 2024
@dh1542 dh1542 self-assigned this Nov 27, 2024
@dh1542 dh1542 moved this from Sprint Backlog to In Progress in amos2024ws01-feature-board Nov 27, 2024
dh1542 added a commit that referenced this issue Nov 27, 2024
@dh1542
#80: Refactoring and moved packages
08e84f8 
Signed-off-by: Dominik Hoffmann <[email protected]>
dh1542 added a commit that referenced this issue Nov 27, 2024
@dh1542
#80: Refactoring project structure according to feedback
ad14bad 
Signed-off-by: Dominik Hoffmann <[email protected]>
dh1542 added a commit that referenced this issue Nov 27, 2024
@dh1542
#80: Refactoring project structure according to feedback
17e4361 
Signed-off-by: Dominik Hoffmann <[email protected]>
dh1542 added a commit that referenced this issue Nov 27, 2024
@dh1542
#80: Refactoring project structure according to feedback. Fixed impor…
53bcfc1 
…ts and black-linted

Signed-off-by: Dominik Hoffmann <[email protected]>
@dh1542 dh1542 linked a pull request Nov 27, 2024 that will close this issue
Project structure feedback #81
Closed
@dh1542 dh1542 moved this from In Progress to Awaiting Review in amos2024ws01-feature-board Nov 27, 2024
dh1542 added a commit that referenced this issue Nov 30, 2024
@dh1542
Merge branch '#80-Refactor-project-structure-according-to-feedback' i…
cbb9316 
…nto #80-project-structure-on-develop

# Conflicts:
#	mkdocs.yml
#	src/sdk/python/rtdip_sdk/pipelines/data_quality/data_manipulation/spark/data_quality/interval_filtering.py
#	src/sdk/python/rtdip_sdk/pipelines/data_quality/monitoring/spark/identify_missing_data_interval.py
#	src/sdk/python/rtdip_sdk/pipelines/data_quality/monitoring/spark/identify_missing_data_pattern.py
#	tests/sdk/python/rtdip_sdk/pipelines/data_quality/data_manipulation/spark/test_duplicate_detection.py
#	tests/sdk/python/rtdip_sdk/pipelines/data_quality/data_manipulation/spark/test_one_hot_encoding.py
#	tests/sdk/python/rtdip_sdk/pipelines/data_quality/monitoring/spark/test_identify_missing_data_interval.py
dh1542 added a commit that referenced this issue Nov 30, 2024
@dh1542
Merge branch 'rtdip:develop' into #80-project-structure-on-develop
629ad54
dh1542 added a commit that referenced this issue Nov 30, 2024
@dh1542
Merge branch '#80-Refactor-project-structure-according-to-feedback' i…
2ed382c 
…nto #80-Refactor-project-structure-develop

# Conflicts:
#	mkdocs.yml
#	src/sdk/python/rtdip_sdk/pipelines/data_quality/data_manipulation/spark/data_quality/interval_filtering.py
#	src/sdk/python/rtdip_sdk/pipelines/data_quality/monitoring/spark/identify_missing_data_interval.py
#	src/sdk/python/rtdip_sdk/pipelines/data_quality/monitoring/spark/identify_missing_data_pattern.py
#	tests/sdk/python/rtdip_sdk/pipelines/data_quality/data_manipulation/spark/test_duplicate_detection.py
#	tests/sdk/python/rtdip_sdk/pipelines/data_quality/data_manipulation/spark/test_one_hot_encoding.py
#	tests/sdk/python/rtdip_sdk/pipelines/data_quality/monitoring/spark/test_identify_missing_data_interval.py
dh1542 added a commit that referenced this issue Nov 30, 2024
@dh1542
#80: Fixed merge problems
06a170f 
Signed-off-by: Dominik Hoffmann <[email protected]>
dh1542 added a commit that referenced this issue Nov 30, 2024
@dh1542
#80: Fixed documentation to suit new structure
ea6f525 
Signed-off-by: Dominik Hoffmann <[email protected]>
dh1542 added a commit that referenced this issue Nov 30, 2024
@dh1542
#80: Fixed documentation to suit new structure
c452701 
Signed-off-by: Dominik Hoffmann <[email protected]>
dh1542 added a commit that referenced this issue Nov 30, 2024
@dh1542
#80: Fixed file path in mds
0594827 
Signed-off-by: Dominik Hoffmann <[email protected]>
@dh1542
Copy link

dh1542 commented Nov 30, 2024

We will go over develop -> merge-to-clone.
#83

mollle added a commit that referenced this issue Dec 1, 2024
@mollle
Merge pull request #83 from amosproj/#80-Refactor-project-structure-d…
4c62ebf 
…evelop

#80 refactor project structure develop
@luccalb luccalb closed this as completed Dec 4, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Review to Feature Archive in amos2024ws01-feature-board Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dh1542 dh1542

Labels
refactoring
Projects
amos2024ws01-feature-board
Status: Feature Archive
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Project structure feedback amosproj/amos2024ws01-rtdip-data-quality-checker
2 participants
@luccalb @dh1542