Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply feedback for interval filtering #74

Closed
2 tasks
luccalb opened this issue Nov 27, 2024 · 0 comments · Fixed by #86
Closed
2 tasks

Apply feedback for interval filtering #74

luccalb opened this issue Nov 27, 2024 · 0 comments · Fixed by #86
Assignees

Comments

@luccalb
Copy link

luccalb commented Nov 27, 2024

Description

  • refactor function

function name could be check_outside_of_interval

and the logic could be;

time_difference = (current_time_stamp - last_time_stamp).total_seconds() * 1000
if not tolerance_in_ms is None:
time_difference += tolerance_in_ms
return time_difference >= time_delta_in_ms

Originally posted by @TugceOzberkYener in #57 (comment)

  • remove forgotten print statement

Originally posted by @TugceOzberkYener in #57 (comment)

Acceptance criteria

Definition of Done

  • Test cases have been created and are running successfully
  • Documentation for the new component was added
  • Github Actions are running without errors
@luccalb luccalb moved this to Product Backlog in amos2024ws01-feature-board Nov 27, 2024
@luccalb luccalb moved this from Product Backlog to Sprint Backlog in amos2024ws01-feature-board Nov 27, 2024
@dh1542 dh1542 self-assigned this Nov 27, 2024
@dh1542 dh1542 moved this from Sprint Backlog to In Progress in amos2024ws01-feature-board Dec 1, 2024
dh1542 added a commit that referenced this issue Dec 1, 2024
@dh1542 dh1542 linked a pull request Dec 1, 2024 that will close this issue
@dh1542 dh1542 moved this from In Progress to Awaiting Review in amos2024ws01-feature-board Dec 1, 2024
FelipeTrost added a commit that referenced this issue Dec 1, 2024
…filtering

#74: Apply feedback for interval filtering
@github-project-automation github-project-automation bot moved this from Awaiting Review to Feature Archive in amos2024ws01-feature-board Dec 1, 2024
@dh1542 dh1542 moved this from Feature Archive to Awaiting Review in amos2024ws01-feature-board Dec 1, 2024
@luccalb luccalb moved this from Awaiting Review to Feature Archive in amos2024ws01-feature-board Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Feature Archive
Development

Successfully merging a pull request may close this issue.

2 participants