Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply feedback for duplicate detection #73

Closed
1 task
luccalb opened this issue Nov 27, 2024 · 0 comments · Fixed by #85
Closed
1 task

Apply feedback for duplicate detection #73

luccalb opened this issue Nov 27, 2024 · 0 comments · Fixed by #85
Assignees
@dh1542
Labels
refactoring

Comments

@luccalb
Copy link

luccalb commented Nov 27, 2024 •
edited
Loading

Description

  • Review the usage of orderBy

I believe we do not need the orderBy to actually implement the function. I guess you needed it to verify the implementation. If that is the case, please remove the orderBy since it is not part of functionality.

Originally posted by @TugceOzberkYener in #57 (comment)

Acceptance criteria

Definition of Done

  • Test cases have been created and are running successfully
  • Documentation for the new component was added
  • Github Actions are running without errors
@luccalb luccalb moved this to Product Backlog in amos2024ws01-feature-board Nov 27, 2024
@luccalb luccalb moved this from Product Backlog to Sprint Backlog in amos2024ws01-feature-board Nov 27, 2024
@dh1542 dh1542 self-assigned this Nov 27, 2024
@dh1542 dh1542 moved this from Sprint Backlog to In Progress in amos2024ws01-feature-board Dec 1, 2024
dh1542 added a commit that referenced this issue Dec 1, 2024
@dh1542
#73: Removed order by
7e97eb4 
Signed-off-by: Dominik Hoffmann <[email protected]>
@dh1542 dh1542 linked a pull request Dec 1, 2024 that will close this issue
Duplicate detection feedback #85
Merged
@dh1542 dh1542 moved this from In Progress to Awaiting Review in amos2024ws01-feature-board Dec 1, 2024
chris-1187 added a commit that referenced this issue Dec 1, 2024
@chris-1187
Merge pull request #85 from amosproj/#73-Apply-feedback-for-duplicate…
22ab57a 
…-detection

Merged as the external API error gets handled separately.
@github-project-automation github-project-automation bot moved this from Awaiting Review to Feature Archive in amos2024ws01-feature-board Dec 1, 2024
@dh1542 dh1542 moved this from Feature Archive to Awaiting Review in amos2024ws01-feature-board Dec 1, 2024
@luccalb luccalb moved this from Awaiting Review to Feature Archive in amos2024ws01-feature-board Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dh1542 dh1542

Labels
refactoring
Projects
amos2024ws01-feature-board
Status: Feature Archive
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Duplicate detection feedback amosproj/amos2024ws01-rtdip-data-quality-checker
2 participants
@luccalb @dh1542