Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete user #151

Merged
merged 24 commits into from
Jan 16, 2023
Merged

Delete user #151

merged 24 commits into from
Jan 16, 2023

Conversation

xilef45
Copy link
Collaborator

@xilef45 xilef45 commented Jan 9, 2023 •
edited by n3rdc4ptn
Loading

For issue: #75

@xilef45 xilef45 linked an issue Jan 9, 2023 that may be closed by this pull request
Delete user #75
Closed
@xilef45 xilef45 marked this pull request as draft January 9, 2023 11:02
@xilef45 xilef45 linked an issue Jan 10, 2023 that may be closed by this pull request
Edit user #74
Closed
@xilef45 xilef45 requested a review from Faoilthiama January 10, 2023 09:35
@n3rdc4ptn n3rdc4ptn changed the title Feature/delte user 75 Delete user Jan 11, 2023
@n3rdc4ptn n3rdc4ptn marked this pull request as ready for review January 11, 2023 12:36
@n3rdc4ptn
Copy link
Contributor

@xilef45 @Faoilthiama Was sind hier noch die letzten ToDos?

@xilef45
Copy link
Collaborator Author

xilef45 commented Jan 16, 2023 •
edited by Faoilthiama
Loading

@xilef45 @Faoilthiama Was sind hier noch die letzten ToDos?

  • Validate if Mail is an vaild Email
  • don't delete User only mark as deleted (as discussed on friday)

Fiona and I will fix these left issues.

n3rdc4ptn and others added 3 commits January 16, 2023 10:12
Faoilthiama
Faoilthiama approved these changes Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@Faoilthiama Faoilthiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find ich gut

@Faoilthiama @xilef45
update tests
5874588 
Co-Authored-By: Felix <[email protected]>
@Faoilthiama Faoilthiama merged commit 31334a7 into develop Jan 16, 2023
@Faoilthiama Faoilthiama deleted the feature/delte-user-75 branch January 16, 2023 13:55
@n3rdc4ptn n3rdc4ptn mentioned this pull request Jan 16, 2023
Closed
@n3rdc4ptn
Copy link
Contributor

closes #158

@n3rdc4ptn n3rdc4ptn linked an issue Jan 16, 2023 that may be closed by this pull request
Error in Input Component #158
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Faoilthiama Faoilthiama Faoilthiama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in Input Component Delete user Edit user
3 participants
@xilef45 @n3rdc4ptn @Faoilthiama