-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add desk #137
feat: add desk #137
Conversation
Co-authored-by: Stefan Pfahler <[email protected]> Signed-off-by: Philipp Wörndle <[email protected]>
Co-authored-by: Stefan Pfahler <[email protected]> Signed-off-by: Philipp Wörndle <[email protected]>
Co-authored-by: Stefan Pfahler <[email protected]> Signed-off-by: Philipp Wörndle <[email protected]>
Co-authored-by: Philipp Wörndle <[email protected]> Signed-off-by: Stefan Pfahler <[email protected]>
Signed-off-by: eddyhakimi <[email protected]>
Signed-off-by: Philipp Wörndle <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Find the frontend implementation great.
Only thing I wasn't sure about: The AddResourceModel is not reseted after adding a desk.
I also commented 2 minors, but nothing problematic.
Everything else works as expected.
Co-authored-by: Stefan Pfahler <[email protected]> Signed-off-by: Philipp Wörndle <[email protected]>
…it jwt-token parameter from FE to BE and adjust FE state logic to add a resource Co-authored-by: Stefan Pfahler <[email protected]> Signed-off-by: Philipp Wörndle <[email protected]>
Co-authored-by: Philipp Wörndle <[email protected]> Signed-off-by: Stefan Pfahler <[email protected]>
The created resources are now returned as request results so they are instantly accessible in the frontend without the need of reloading the ui to fetch them. Co-authored-by: Philipp Wörndle <[email protected]> Signed-off-by: Stefan Pfahler <[email protected]>
Co-authored-by: Philipp Wörndle <[email protected]> Signed-off-by: Stefan Pfahler <[email protected]>
Co-authored-by: Philipp Wörndle <[email protected]> Signed-off-by: Stefan Pfahler <[email protected]>
566017e
to
05730b9
Compare
We keep the form after creating a desk to make it easier for a user to create multiple in sequence. If we always clear the forms after creating a resource, the user would have to input all of the information again to create another resource. |
Co-authored-by: Philipp Wörndle <[email protected]> Signed-off-by: Stefan Pfahler <[email protected]>
…terias Co-authored-by: Stefan Pfahler <[email protected]> Signed-off-by: Philipp Wörndle <[email protected]>
Co-authored-by: Philipp Woerndle <[email protected]> Signed-off-by: Stefan Pfahler <[email protected]>
No description provided.