Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add desk #137

Merged
merged 16 commits into from
Jan 5, 2023
Merged

feat: add desk #137

merged 16 commits into from
Jan 5, 2023

Conversation

woerndle
Copy link
Collaborator

No description provided.

woerndle and others added 7 commits December 7, 2022 22:40
Co-authored-by: Stefan Pfahler <[email protected]>
Signed-off-by: Philipp Wörndle <[email protected]>
Co-authored-by: Stefan Pfahler <[email protected]>
Signed-off-by: Philipp Wörndle <[email protected]>
Co-authored-by: Stefan Pfahler <[email protected]>
Signed-off-by: Philipp Wörndle <[email protected]>
Co-authored-by: Philipp Wörndle <[email protected]>
Signed-off-by: Stefan Pfahler <[email protected]>
Signed-off-by: Philipp Wörndle <[email protected]>
Copy link
Collaborator

@eddyhakimi eddyhakimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find the frontend implementation great.
Only thing I wasn't sure about: The AddResourceModel is not reseted after adding a desk.
I also commented 2 minors, but nothing problematic.
Everything else works as expected.

woerndle and others added 6 commits December 17, 2022 12:19
Co-authored-by: Stefan Pfahler <[email protected]>
Signed-off-by: Philipp Wörndle <[email protected]>
…it jwt-token parameter from FE to BE and adjust FE state logic to add a resource

Co-authored-by: Stefan Pfahler <[email protected]>
Signed-off-by: Philipp Wörndle <[email protected]>
Co-authored-by: Philipp Wörndle <[email protected]>
Signed-off-by: Stefan Pfahler <[email protected]>
The created resources are now returned as request
results so they are instantly accessible in the
frontend without the need of reloading the ui to
fetch them.

Co-authored-by: Philipp Wörndle <[email protected]>
Signed-off-by: Stefan Pfahler <[email protected]>
Co-authored-by: Philipp Wörndle <[email protected]>
Signed-off-by: Stefan Pfahler <[email protected]>
Co-authored-by: Philipp Wörndle <[email protected]>
Signed-off-by: Stefan Pfahler <[email protected]>
@stefanpfahler
Copy link
Collaborator

Find the frontend implementation great. Only thing I wasn't sure about: The AddResourceModel is not reseted after adding a desk. I also commented 2 minors, but nothing problematic. Everything else works as expected.

We keep the form after creating a desk to make it easier for a user to create multiple in sequence. If we always clear the forms after creating a resource, the user would have to input all of the information again to create another resource.

Co-authored-by: Philipp Wörndle <[email protected]>
Signed-off-by: Stefan Pfahler <[email protected]>
woerndle and others added 2 commits January 2, 2023 20:56
…terias

Co-authored-by: Stefan Pfahler <[email protected]>
Signed-off-by: Philipp Wörndle <[email protected]>
Co-authored-by: Philipp Woerndle <[email protected]>
Signed-off-by: Stefan Pfahler <[email protected]>
@stefanpfahler stefanpfahler merged commit 58d1387 into develop Jan 5, 2023
@stefanpfahler stefanpfahler deleted the 54-add-desk branch January 5, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants