fix: edit desk types error messages

Co-authored-by: Stefan Pfahler <[email protected]> Signed-off-by: Philipp Wörndle <[email protected]>
amosproj · Jan 30, 2023 · a62ec84 · a62ec84
1 parent fc524f2
commit a62ec84
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/deskstar-backend/Deskstar/Usecases/ResourceUsecases.cs b/src/deskstar-backend/Deskstar/Usecases/ResourceUsecases.cs
@@ -232,7 +232,7 @@ public DeskType UpdateDeskType(Guid companyId, Guid deskTypeId, string? deskType
       throw new EntityNotFoundException($"There is no desk type with id '{deskTypeId}'");
 
     if (deskTypeExists.CompanyId != companyId)
-      throw new InsufficientPermissionException($"'{companyId}' has no access to administrate desk type '{deskTypeId}'");
+      throw new InsufficientPermissionException($"Your company has no access to administrate desk type '{deskTypeExists.DeskTypeName}'");
 
     //change deskTypeName
     if (deskTypeName != null)

diff --git a/src/deskstar-backend/Teststar.Tests/Tests/ResourceUsecaseTests.cs b/src/deskstar-backend/Teststar.Tests/Tests/ResourceUsecaseTests.cs
@@ -2088,7 +2088,8 @@ public void UpdateDeskType_WhenDeskTypeDoesBelongToDifferentCompany_ShouldThrowI
 
     var companyId = Guid.NewGuid();
     var deskTypeId = Guid.NewGuid();
-    var deskType = new DeskType { CompanyId = companyId, DeskTypeId = deskTypeId, DeskTypeName = "testdesktype" };
+    var deskTypeName = "testdesktype";
+    var deskType = new DeskType { CompanyId = companyId, DeskTypeId = deskTypeId, DeskTypeName = deskTypeName };
 
     context.DeskTypes.Add(deskType);
     context.SaveChanges();
@@ -2103,7 +2104,7 @@ public void UpdateDeskType_WhenDeskTypeDoesBelongToDifferentCompany_ShouldThrowI
     // act+assert
     var ex = Assert.Throws<InsufficientPermissionException>(() => resourceUsecases.UpdateDeskType(noPermissionCompanyId, deskTypeId, null));
     Assert.NotNull(ex);
-    Assert.That(ex.Message, Is.EqualTo($"'{noPermissionCompanyId}' has no access to administrate desk type '{deskTypeId}'"));
+    Assert.That(ex.Message, Is.EqualTo($"Your company has no access to administrate desk type '{deskTypeName}'"));
 
     // cleanup
     context.Database.EnsureDeleted();